Skip to content

Fix err shadowing in gcs driver #3127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2020
Merged

Fix err shadowing in gcs driver #3127

merged 1 commit into from
Mar 19, 2020

Conversation

dmage
Copy link
Contributor

@dmage dmage commented Mar 18, 2020

The error from wc.Write exists only in the loop scope, therefore wc.CloseWithError is never called.

@dmage
Fix err shadowing in gcs driver
cdb4ba9 
Signed-off-by: Oleg Bulatov <oleg@bulatov.me>
dmcgowan
dmcgowan approved these changes Mar 19, 2020
View reviewed changes
Copy link
Collaborator

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan merged commit 742aab9 into distribution:master Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmage @dmcgowan