Add pathspec for repo _layers directory and allow Repository.BlobStore to enumerate over blobs #3061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 5, 2019 20:48
Signed-off-by: Guillaume Rose <guillaume.rose@docker.com>
Signed-off-by: Guillaume Rose <guillaume.rose@docker.com>
Signed-off-by: Guillaume Rose <guillaume.rose@docker.com>
b4dfd94 to
5538da4
Compare
Codecov Report
@@ Coverage Diff @@
## master #3061 +/- ##
==========================================
+ Coverage 60.73% 60.74% +<.01%
==========================================
Files 102 102
Lines 8073 8077 +4
==========================================
+ Hits 4903 4906 +3
- Misses 2518 2519 +1
Partials 652 652
Continue to review full report at Codecov.
|
|
@guillaumerose I wonder if we can add tests for |
Signed-off-by: Guillaume Rose <guillaume.rose@docker.com>
5ee48a0 to
c9c3324
Compare
|
I added 2 extra unit tests. It should be better now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code is already used by Hub and helps us GC old content.