Skip to content

Conversation

kd7lxl
Copy link
Contributor

@kd7lxl kd7lxl commented Oct 7, 2019

Noticed a typo in the CloudFront storage configuration keys. This is likely to cause errors for people who are typing rather than copy/pasting and don't reproduce the typo in their config. I have fixed the typo here and supported the old key for backwards compatibility.

@codecov
Copy link

codecov bot commented Oct 7, 2019

Codecov Report

Merging #3020 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3020   +/-   ##
=======================================
  Coverage   60.74%   60.74%           
=======================================
  Files         102      102           
  Lines        8077     8077           
=======================================
  Hits         4906     4906           
  Misses       2519     2519           
  Partials      652      652
Flag Coverage Δ
#linux 60.74% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdf3438...0f5e275. Read the comment docs.

@dmcgowan
Copy link
Collaborator

Looks good, can you rebase then we can get it merged

Signed-off-by: Tom Hayward <thayward@infoblox.com>
@kd7lxl
Copy link
Contributor Author

kd7lxl commented Dec 13, 2019

@dmcgowan Rebased.

Copy link
Collaborator

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan merged commit bfa6b92 into distribution:master Feb 23, 2020
@kd7lxl kd7lxl deleted the updatefrequency branch July 23, 2020 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants