Skip to content

Conversation

bouk
Copy link
Contributor

@bouk bouk commented Aug 22, 2019

No description provided.

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "rempo" git@github.com:bouk/distribution.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

Signed-off-by: Bouke van der Bijl <me@bou.ke>
@codecov
Copy link

codecov bot commented Sep 2, 2019

Codecov Report

Merging #2984 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2984      +/-   ##
==========================================
- Coverage   60.69%   60.64%   -0.05%     
==========================================
  Files         102      102              
  Lines        8044     8044              
==========================================
- Hits         4882     4878       -4     
- Misses       2511     2514       +3     
- Partials      651      652       +1
Flag Coverage Δ
#linux 60.64% <100%> (-0.05%) ⬇️
Impacted Files Coverage Δ
registry/handlers/app.go 48.16% <100%> (-0.7%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fb7fff...1c481d3. Read the comment docs.

Copy link
Contributor

@caervs caervs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@caervs caervs merged commit f656e60 into distribution:master Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants