Update the versions of several dependencies #2947
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…encies Signed-off-by: Tariq Ibrahim <tariq181290@gmail.com>
1f06e87 to
afe29bb
Compare
Codecov Report
@@ Coverage Diff @@
## master #2947 +/- ##
=======================================
Coverage 60.45% 60.45%
=======================================
Files 102 102
Lines 8002 8002
=======================================
Hits 4838 4838
Misses 2515 2515
Partials 649 649
Continue to review full report at Codecov.
|
|
@caervs @manishtomar Requesting your review :). |
caervs
approved these changes
Jun 28, 2019
There was a problem hiding this comment.
LGTM!
Also did an internal build of DTR with this change and ran our full integration test suite against it which passed 👍
@manishtomar PTAL
|
@manishtomar Would you be able to approve this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the following dependencies
i) spf13/cobra
ii) sirupsen/logrus
iii)golang.org/x/crypto
iv)gorilla/mux
v)golang.org/x/oauth2
vi)ncw/swift
It also updates the Go version to
1.12.x