Implement Repository ServeBlob #2921
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caervs
suggested changes
May 15, 2019
registry/client/repository.go
Outdated
| w.Header().Set("Docker-Content-Digest", dgst.String()) | ||
| w.Header().Set("Etag", dgst.String()) | ||
|
|
||
| if r.Method == "HEAD" { |
There was a problem hiding this comment.
nit: would use http.MethodHead so we have some validation of the value
| return err | ||
| } | ||
|
|
||
| w.Header().Set("Content-Length", strconv.FormatInt(desc.Size, 10)) |
There was a problem hiding this comment.
These headers re-appear quite a bit
Makes mental note that we should have a utility function for setting them
caervs
approved these changes
May 16, 2019
added 2 commits
June 25, 2019 09:30
Signed-off-by: Damien Mathieu <dmathieu@salesforce.com>
A registry pointing to ECR is having issues if we try loading the blob Signed-off-by: Damien Mathieu <dmathieu@salesforce.com>
Codecov Report
@@ Coverage Diff @@
## master #2921 +/- ##
=========================================
+ Coverage 60.45% 60.5% +0.04%
=========================================
Files 102 102
Lines 8002 8016 +14
=========================================
+ Hits 4838 4850 +12
Misses 2515 2515
- Partials 649 651 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.