Handle Blob Create when the underlying registry doesn't provide 'Docker-Upload-UUID' #2927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please sign your commits following these rules: $ git clone -b "blob-create-uuid" git@github.com:dmathieu/distribution.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842358448512
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
added 2 commits
June 25, 2019 09:29
Some registries (ECR) don't provide a `Docker-Upload-UUID` when creating a blob. So we can't rely on that header. Fallback to reading it from the URL. Signed-off-by: Damien Mathieu <dmathieu@salesforce.com>
Signed-off-by: Damien Mathieu <dmathieu@salesforce.com>
Codecov Report
@@ Coverage Diff @@
## master #2927 +/- ##
==========================================
+ Coverage 60.45% 60.48% +0.02%
==========================================
Files 102 102
Lines 8002 8007 +5
==========================================
+ Hits 4838 4843 +5
Misses 2515 2515
Partials 649 649
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some registries, such as ECR don't provide a
Docker-Upload-UUIDHTTP header when starting a blob upload. So we can't rely on that, which then fails when we try to generate theLocationheader we return (in blobupload.go).This fallbacks to try reading the UUID from the Location header returned by the underlying service. If we still don't have any UUID, it then returns an error.
I didn't remove @dmcgowan's TODO because we're technically still not checking for invalid UUID, only for empty strings.