Test httpBlobUpload.Write method #2918
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Damien Mathieu <dmathieu@salesforce.com>
Codecov Report
@@ Coverage Diff @@
## master #2918 +/- ##
=========================================
+ Coverage 60.45% 60.5% +0.04%
=========================================
Files 102 102
Lines 8002 8002
=========================================
+ Hits 4838 4842 +4
+ Misses 2515 2513 -2
+ Partials 649 647 -2
Continue to review full report at Codecov.
|
davidswu
approved these changes
Jun 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Writemethod ofhttpBlobUploadwasn't being tested. I've copied theReadFromtests usingWriteinstead.It's very similar to
ReadFromwith the exception that the latter doesn't include anyContent-*HTTP headers, because it can't know the size of a reader.We could merge them to avoid repetition. But we'd then have to turn the reader into a bytes slice and back into a reader (for
http.NewRequest).