Implement Repository Blobs upload resuming #2917
Conversation
|
The tests failure appears to be due to vendor issues, not related to this change. |
| StatusCode: http.StatusOK, | ||
| Headers: http.Header(map[string][]string{ | ||
| "Content-Length": {fmt.Sprint(len(b1))}, | ||
| "Last-Modified": {time.Now().Add(-1 * time.Second).Format(time.ANSIC)}, |
There was a problem hiding this comment.
Can timing for this test cause random failures?
There was a problem hiding this comment.
I've not seen any failure. The pattern is also used in several other places (I see 16 occurences in this file).
|
Please sign your commits following these rules: $ git clone -b "repository-blob-resume" git@github.com:dmathieu/distribution.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842357576592
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
|
Looks like this needs to be rebased. |
Signed-off-by: Damien Mathieu <dmathieu@salesforce.com>
Codecov Report
@@ Coverage Diff @@
## master #2917 +/- ##
==========================================
- Coverage 60.59% 60.59% -0.01%
==========================================
Files 102 102
Lines 8025 8034 +9
==========================================
+ Hits 4863 4868 +5
- Misses 2512 2514 +2
- Partials 650 652 +2
Continue to review full report at Codecov.
|
This implements resuming a repository blobs upload.
I'm using
time.NowasstartedAt, as the one set whenCreate()was called doesn't seem to be available. I'm happy to follow any guidance on using another value though.