fix no error returned in fetchTokenWithOAuth #2900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fetchTokenWithBasicAuth checks if a token is in the token response but fetchTokenWithOAuth does not these changes implements the same behaviour for the latter returning a `ErrNoToken` if a token is not found in the resposne Signed-off-by: Sevki Hasirci <sevki@cloudflare.com>
Codecov Report
@@ Coverage Diff @@
## master #2900 +/- ##
==========================================
- Coverage 60.45% 60.43% -0.02%
==========================================
Files 102 102
Lines 8001 8003 +2
==========================================
Hits 4837 4837
- Misses 2517 2518 +1
- Partials 647 648 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fetchTokenWithBasicAuth checks if a token is in the token response
but fetchTokenWithOAuth does not
these changes implements the same behaviour for the latter
returning a
ErrNoTokenif a token is not found in the resposneSigned-off-by: Sevki Hasirci sevki@cloudflare.com