-
Notifications
You must be signed in to change notification settings - Fork 2.6k
support Alibaba Cloud CDN storage middleware #2849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Please sign your commits following these rules: $ git clone -b "master" git@github.com:Shawnpku/distribution.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f Amending updates the existing PR. You DO NOT need to open a new one. |
Signed-off-by: Shawnpku <chen8132@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't do a full review, but I saw this PR, and my eye fell on these 😅
@thaJeztah Thank you so much for the review. Already fixed. |
@thaJeztah Check the changes at your convenient. Thanks. |
Thanks for updating! I'm not a maintainer in this repository, so I'll leave the more in-depth review to the maintainers (I just spotted those small issues 🤗 ) |
oh! I see you missed a DCO sign-off on the second commit; could you
So
Instead of
|
Signed-off-by: Shawnpku <chen8132@gmail.com>
Please take a look @dmcgowan @caervs @manishtomar. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff! Just one question.
Let's ship on green. Let us know if you have any questions about CI.
Signed-off-by: Shawnpku <chen8132@gmail.com>
Signed-off-by: Shawn Chen <chen8132@gmail.com>
Signed-off-by: Shawn Chen <chen8132@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2849 +/- ##
=======================================
Coverage 60.45% 60.45%
=======================================
Files 102 102
Lines 8001 8001
=======================================
Hits 4837 4837
Misses 2517 2517
Partials 647 647
Continue to review full report at Codecov.
|
@caervs I think this is good now. |
@manishtomar would you like to take a review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM. However, please change the package name and put it up for review again.
Signed-off-by: Shawn Chen <chen8132@gmail.com>
@manishtomar Thank you for the review. Changes applied. |
Signed-off-by: Shawn Chen <chen8132@gmail.com>
@dmcgowan @caervs @manishtomar Could someone merge this PR if it is good now. Thanks. |
Add support for Alibaba Cloud CDN (Content Delivery Network) when using OSS storage.