registry: fix binary JSON content-type #2813
Conversation
This fixes registry endpoints to return the proper `application/json` content-type for JSON content, also updating spec examples for that. As per IETF specification and IANA registry [0], the `application/json` type is a binary media, so the content-type label does not need any text-charset selector. Additionally, the media type definition explicitly states that it has no required nor optional parameters, which makes the current registry headers non-compliant. [0]: https://www.iana.org/assignments/media-types/application/json Signed-off-by: Luca Bruno <lucab@debian.org>
Codecov Report
@@ Coverage Diff @@
## master #2813 +/- ##
=======================================
Coverage 60.25% 60.25%
=======================================
Files 103 103
Lines 8024 8024
=======================================
Hits 4835 4835
Misses 2546 2546
Partials 643 643
Continue to review full report at Codecov.
|
|
@dmcgowan @caervs can you please have a quick look? This is a minor bugfix that primarily adjusts specs and code to avoid any ambiguities on unexpected |
|
Corresponding OCI distribution-spec change is up at opencontainers/distribution-spec#41. |
There was a problem hiding this comment.
LGTM but let's hold off on merging until we resolve the discussion in opencontainers/distribution-spec#41
Thanks @lucab!
|
Bump, the OCI distribution-spec counterpart of this got merged today. |
This fixes registry endpoints to return the proper
application/jsoncontent-type for JSON content, also updating spec examples for that.
As per IETF specification and IANA registry 0, the
application/jsontype is a binary media, so the content-type label does not need any
text-charset selector. Additionally, the media type definition
explicitly states that it has no required nor optional parameters,
which makes the current registry headers non-compliant.
Signed-off-by: Luca Bruno lucab@debian.org