Skip to content

Conversation

caervs
Copy link
Contributor

@caervs caervs commented Jan 4, 2019

Config parameter is user facing so should be documented.

Signed-off-by: Ryan Abrams rdabrams@gmail.com

@caervs
Copy link
Contributor Author

caervs commented Jan 4, 2019

Depends on #2800 and addresses #2793

Copy link
Contributor

@davidswu davidswu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Config parameter is user facing so should be documented.

Signed-off-by: Ryan Abrams <rdabrams@gmail.com>
@codecov
Copy link

codecov bot commented Jan 4, 2019

Codecov Report

Merging #2801 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2801   +/-   ##
=======================================
  Coverage   60.24%   60.24%           
=======================================
  Files         103      103           
  Lines        8022     8022           
=======================================
  Hits         4833     4833           
  Misses       2546     2546           
  Partials      643      643
Flag Coverage Δ
#linux 60.24% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40b7b58...d1abdeb. Read the comment docs.

@dmcgowan
Copy link
Collaborator

dmcgowan commented Jan 7, 2019

LGTM

@dmcgowan dmcgowan merged commit 91b0f05 into distribution:master Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants