Skip to content

Conversation

andyzhangx
Copy link
Contributor

The default Dockerfile won't work in docker proxy pull cache mode, error will happen:

panic: Get https://xxx/v2/: x509: certificate signed by unknown authority

This PR use the config from distribution-library-image directly
https://github.com/docker/distribution-library-image/blob/7d18dca46fba84ec5a2a70e0ac81113975c3a159/amd64/Dockerfile#L3-L6

@manishtomar

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "ssl" git@github.com:andyzhangx/distribution.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

Signed-off-by: andyzhangx <xiazhang@microsoft.com>
@codecov
Copy link

codecov bot commented Jan 10, 2019

Codecov Report

Merging #2809 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2809   +/-   ##
=======================================
  Coverage   60.25%   60.25%           
=======================================
  Files         103      103           
  Lines        8024     8024           
=======================================
  Hits         4835     4835           
  Misses       2546     2546           
  Partials      643      643
Flag Coverage Δ
#linux 60.25% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91b0f05...7df881d. Read the comment docs.

Copy link
Contributor

@caervs caervs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants