Convert to go modules. #2768
Convert to go modules. #2768
Conversation
|
Please sign your commits following these rules: $ git clone -b "prom_vendor" git@github.com:SuperQ/distribution.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
78a2e89 to
6e0b993
Compare
|
why is this abandoned? are there no plans to get this in the master? |
|
@sevki Good question, I have a hard time getting Docker people to review things here. |
62873b5 to
db12ac8
Compare
|
Ugh, gometalinter is such a pain. |
* Replace vendor.conf with go.mod. * Fix aliases import of `github.com/dmcgowan/letsencrypt` fork. * Minimal vendoring changes. * Download gometalinter binary. * Disable slow "goimports" test. Signed-off-by: Ben Kochie <superq@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2768 +/- ##
=======================================
Coverage 60.45% 60.45%
=======================================
Files 102 102
Lines 8001 8001
=======================================
Hits 4837 4837
Misses 2517 2517
Partials 647 647
Continue to review full report at Codecov.
|
|
So, there are a bunch of errors I can't quite figure out with gometalinter. Apparently this tool is deprecated and is replaced by golangci-lint. But that tool seems like it requires switching to Go modules first. :-/ |
|
oh wow. you've made the tests pass!!!! 🎉 🎉 🎉 @manishtomar can you take a look? |
|
Yea, I cheated. I gave up after several hours of messing around with it. There are a bunch of |
|
Maybe we can get some guidance from the docker folks, I'll also fiddle with it and see if I can make it work. |
github.com/dmcgowan/letsencryptfork.