Fix the pointer initialization #2446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the overwriteStruct() finds an uninitialized pointer, it tries to initialize it, but does it incorrectly. It tries to assign a pointer to pointer, instead of pointer. Signed-off-by: Gladkov Alexey <agladkov@redhat.com>
Codecov Report
@@ Coverage Diff @@
## master #2446 +/- ##
==========================================
- Coverage 60.32% 50.76% -9.56%
==========================================
Files 126 126
Lines 14436 14436
==========================================
- Hits 8708 7329 -1379
- Misses 4844 6363 +1519
+ Partials 884 744 -140
Continue to review full report at Codecov.
|
|
Can you add a unit test for this? |
|
@zhouhaibing089 Sure. Done. |
Signed-off-by: Gladkov Alexey <agladkov@redhat.com>
888b248 to
e698374
Compare
|
@RichardScothern please review |
RobbKistler
approved these changes
Aug 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
overwriteStruct()finds an uninitialized pointer, it tries to initialize it, but does it incorrectly. It tries to assign a pointer to pointer, instead of pointer.