Remove max repository component length restriction #242
Conversation
f954155 to
9298f35
Compare
|
@stevvooe spurious unrelated test failure? |
|
Seems that one is popping from time to time... |
|
@dmp42 can you kick circle to get it to retest? |
|
Restarted. |
|
@ncdc While we're at it, should we remove |
|
@ncdc Also, let's update the specification (doc/spec/api.md). |
So there's no longer a need to restrict it to 5?
Will do, once we settle on |
|
@stevvooe the spec currently says that a name must have at least 2 components and must be less than 256 characters. The only mention of a 30-character limit is a reference to the repository names as we know of them today. There is also no mention of a maximum of 5 components. |
|
LGTM! |
|
@stevvooe did you want to remove the 5 component max? |
|
@ncdc Please go ahead. |
|
@stevvooe ok, will do |
|
@stevvooe 5 max removed. I can squash if you need. |
|
LGTM |
| // RepositoryNameMinComponents is the minimum number of slash-delimited | ||
| // components that a repository name must have | ||
| RepositoryNameMinComponents = 1 | ||
|
|
||
| // RepositoryNameMaxComponents is the maximum number of slash-delimited | ||
| // components that a repository name must have | ||
| RepositoryNameMaxComponents = 5 |
There was a problem hiding this comment.
RepositoryNameRegexp needs to be modified to not restrict this, as well.
There was a problem hiding this comment.
Sorry, forgot to make that change. I knew that was there but with
everything going on today I missed it. I'll get it in later tonight.
On Fri, Mar 6, 2015 at 6:03 PM Stephen Day notifications@github.com wrote:
In registry/api/v2/names.go
#242 (comment):// RepositoryNameMinComponents is the minimum number of slash-delimited // components that a repository name must have RepositoryNameMinComponents = 1
- // RepositoryNameMaxComponents is the maximum number of slash-delimited
- // components that a repository name must have
- RepositoryNameMaxComponents = 5
RepositoryNameRegexp needs to be modified to not restrict this, as well.
—
Reply to this email directly or view it on GitHub
https://github.com/docker/distribution/pull/242/files#r25985918.
Fixes distribution#241 Signed-off-by: Andy Goldstein <agoldste@redhat.com>
97bb8d5 to
e1e7248
Compare
|
LGTM! |
Remove max repository component length restriction
…ngth Remove max repository component length restriction
…ngth Remove max repository component length restriction
Fixes #241
Signed-off-by: Andy Goldstein agoldste@redhat.com