Rename cloud make targets to s3 #4600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally we used to have integration tests only for S3 so we decided to call them "clooud" (tests). We've now added integration tests for Azure storage driver so calling the S3 one cloud is just opaque and rather confusing. This commit renamed -cloud- targets to -s3- ones. Signed-off-by: Milos Gajdos <milosthegajdos@gmail.com>
Renamed some additional files that were missed in the first commit. Signed-off-by: Milos Gajdos <milosthegajdos@gmail.com>
joaodrp
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, we used to have integration tests only for S3 storage driver, so when we introduced them we decided to call them "cloud" (tests).
We've recently added integration tests for Azure storage driver, too, so calling the S3 ones "cloud" is just opaque and rather confusing. This PR renames
*-cloud-*targets to*-s3-*ones.PTAL @thaJeztah