Skip to content

Conversation

alistair
Copy link

This PR builds on the work of #3834

First commit is the rebasing of the previous PR onto the latest commit.
Second commit extends this to also include support for oci image indexes

Thank you @brackendawson

This implements support for the previously ignored subject property on OCI Image manifests by creating a link to the referrer under the subject, which will be needed for the artifact listing API.

This pull request is based on #3833 which should be reviewed first and then this re-based.

Adresses #3716

teambush1 and others added 2 commits October 13, 2024 21:02
Signed-off-by: Alistair Bush <alistair.bush@gmail.com>
Co-authored-by: Alistair Bush <alistair.bush@gmail.com>
Co-authored-by: Bracken Dawson <abdawson@gmail.com>
Signed-off-by: Alistair Bush <alistair.bush@gmail.com>
@teambush1 teambush1 force-pushed the image-manigest-subjects branch from ff50e7a to 385a49b Compare October 13, 2024 08:04
Signed-off-by: Alistair Bush <alistair.bush@gmail.com>
@milosgajdos
Copy link
Member

Thanks for the PR! Just to give you a heads up, it's very unlikely this will snuck in into the v3 stable release (no plan on ETA) due to the blast radius of this change. I just want to set the expectations here!

@alistair
Copy link
Author

@milosgajdos Completely understand. My main motivation for this was to see if I could implement the API . which if you are interested in a unfinished version is located here

Could I suggest that a way to include the subject functionality before the v3 could be to include it as a experimental feature. Effectively this proposal would add the following to the config yaml

experiments:
   subjects: true

The api and write paths could then both be implemented behind the feature flag providing the ability to incrementally deliver this solution without releasing. Users would be able to enable it at their own risk.

This is obviously your decision to make. I know that projects like harbor implement the subject functionality independently of the registry itself so it might be useful in the future to provide that feature flag regardless.

@SuperSandro2000
Copy link

This change is required to implement the referer API in a consuming application I maintain. Is there a better alternative than waiting or vendoring the code in our application?

@milosgajdos
Copy link
Member

Maybe some other OSS implementation provider referrer API implementation but it's not currently planned in upstream. First we want to make a stable release and then discuss what next if anything. There has been no support from CNCF and negligible activity from most of the maintainers, so I would not rely / wait for this

@brackendawson
Copy link
Contributor

Thanks for the re-base and the work @alistair. I've moved to a role that doesn't deal with the registry much any more. So the chances of me getting this across the line is slim. Anyone else is welcome to pick this up or do it green field.

@milosgajdos
Copy link
Member

This is failing CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants