replace uses of Descriptor alias #4479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
thaJeztah
commented
Oct 7, 2024
- follow-up to Make Descriptor an alias for oci.Descriptor #3888
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
27bc855 to
0ab7f32
Compare
milosgajdos
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
Oh wow, thanks for all this legwork! James, mind having a look 😇 @Jamstah
|
Yeah, not strictly needed I guess (which is why I kept it separate), but I thought it'd be more clear to no longer depend on the alias; potentially we could even consider phasing out the alias entirely (as it's merely there for convenience now?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.