-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Add a note regarding redirects to pre-signed URLs #4466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
docs/content/storage-drivers/s3.md
Outdated
@@ -7,6 +7,9 @@ title: S3 storage driver | |||
An implementation of the `storagedriver.StorageDriver` interface which uses | |||
Amazon S3 or S3 compatible services for object storage. | |||
|
|||
> **Note** When S3 storage is used, registry redirects to a pre-signed URL for the requested object. | |||
> It allows to deploy a thin host with registry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean by "thin host" here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Host with a few or even single vCPU, GiB of memory, and low network throughput.
From the documentation, it could be more explicit about what S3 storage does under the hood. For all the time I've been using registry:2
, we deployed hosts with high network bandwidth and relatively big local disks for caching proxy. Because S3 just looked like exactly "storage", where objects would be transferred from the S3 to clients via the registry itself, and the traffic would be even more significant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah gotchya! Thanks. I am not sure mentioning this adds any value to technical documentation. If we do want to add a note like that I'd suggest rephrasing it to something like
By not having to serve the stored images directly, this allows running registry on hosts with lightweight resource requirements
WDYT? CC @thaJeztah @Jamstah @squizzi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, looks good 👍
Regarding the value, I literally didn't know that the registry provides such a useful feature, and I couldn't find it anywhere in the docs. Knowing it years ago would save me a lot of slapping stuff together to decrease our costs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should have stressed that I do not question this:
Note When S3 storage is used, registry redirects to a pre-signed URL for the requested object.
My point was more about
It allows to deploy a thin host with registry.
Signed-off-by: Mikhail f. Shiryaev <mr.felixoid@gmail.com>
Figuring out what
S3
storage does under the hood was tricky. I hope this small note will help other people set up the infrastructure.