Skip to content

manifest: slight cleanup of init / registration #4403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2024
Merged

manifest: slight cleanup of init / registration #4403

merged 1 commit into from
Jul 18, 2024

Conversation

thaJeztah
Copy link
Member

Change the marshal-funcs to a regular function instead of definining as part of an init and remove some intermediate variables.

@thaJeztah
manifest: slight cleanup of init / registration
3d0239a 
Change the marshal-funcs to a regular function instead of definining
as part of an init and remove some intermediate variables.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
wy65701436
wy65701436 approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 merged commit e050331 into distribution:main Jul 18, 2024
16 checks passed
joaodrp
joaodrp reviewed Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@joaodrp joaodrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thaJeztah thaJeztah deleted the cleaner_init branch July 18, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaodrp joaodrp joaodrp left review comments

@milosgajdos milosgajdos milosgajdos approved these changes

@wy65701436 wy65701436 wy65701436 approved these changes

@corhere corhere Awaiting requested review from corhere

@Jamstah Jamstah Awaiting requested review from Jamstah

@squizzi squizzi Awaiting requested review from squizzi

@deleteriousEffect deleteriousEffect Awaiting requested review from deleteriousEffect

@davidspek davidspek Awaiting requested review from davidspek

Assignees
No one assigned
Labels
refactor status/2-code-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thaJeztah @joaodrp @milosgajdos @wy65701436