docs: disable base element override #4391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting the HTML <base> element causes page-internal links to point to the root of the website, rather than local anchors on the same page. Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
|
@dvdksn will this break any existing functionality? The geekdocs docs (that's a mouthful) specify using this option to get markdown images/links working. |
|
@squizzi I couldn't see that anything broke from this change. Images still show, at least on local preview, and I don't see any broken links ( |
|
Is there anywhere we can see the preview of this fix, @dvdksn |
|
@milosgajdos I tried to upload here: https://registry.surge.sh/ It doesn't have the |
|
@thaJeztah wanna have a look at this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like the
geekdocOverwriteHTMLBaseconfiguration option caused local links URL fragments to target the root URL of the site, rather than the current page.Closes #4388