fix logic for handling regionEndpoint #4341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the current logic we only verifies the region and return if it's empty; we were not validating the regionEndpoint parameter. Signed-off-by: Ankur Kothiwal <ankur.kothiwal@cern.com>
|
Can you point me to some docs that say the region endpoint does have a preference over setting just the region. I've hacked up a quick test and it seems to be the case, but it'd be great to point users in some direction in case this gets brought up in the future |
|
I couldn't find the doc saying that the region endpoint is preferred over setting the region, but if we see here, it mentions that we have to specify an endpoint even if region is applied. This I believe is due to the logic that we check the regionName parameter before the regionEndpoint value. |
milosgajdos
approved these changes
May 20, 2024
Jamstah
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current logic only checks the region and returns if it's empty; however, we are not validating the regionEndpoint parameter. Therefore, if the user provides only the regionEndpoint without any region, this will not be evaluated.