Add a go.mod toolchain version #4347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
go 1.21 added toolchain support. We should now specify a toolchain version in go.mod. https://go.dev/doc/toolchain Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com>
|
Curious: what are we gaining with this? |
|
For one, the removal of a security warning: https://github.com/distribution/distribution/security/code-scanning/tools/CodeQL/status/configurations/actions-FZTWS5DIOVRC653POJVWM3DPO5ZS6Y3PMRSXC3BNMFXGC3DZONUXGLTZNVWA/aeb963eb3dd5cba62a5b17e8ad9ab76aeb67a2c8d843237c097778647c7eaf69 Other than that, assurance that developers are using a toolchain that is as new as the one we are building the project with. |
squizzi
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go 1.21 added toolchain support. We should now specify a toolchain version in go.mod.
https://go.dev/doc/toolchain