Skip to content

Conversation

markuskirch
Copy link

Currently, the documentation lacks information about the jwks parameter added by #4096

This PR attempts to append the documentation.

Note:
Appending the token or jwt docs with an in-depth explanation of how the jwks parameter will affect the authentication process would probably be helpful.

@milosgajdos
Copy link
Member

Please sign your commit

@markuskirch
Copy link
Author

I signed my commit. Why does it say I didn't?

@milosgajdos
Copy link
Member

You are using wrong email in your signature -- use the one u configured your github with

Commit sha: e3c41d2, Author: markus, Committer: markus; Expected "markus markus@happy-camel.de", but got "Markus Kirch mail@markus-kirch.de".

Signed-off-by: Markus Kirch <mail@markus-kirch.de>
@markuskirch
Copy link
Author

markuskirch commented May 9, 2024

Thanks for pointing that out. Apparently, I never updated my local .gitconfig when switching email addresses way back.
Fixed this now.

@milosgajdos
Copy link
Member

@markuskirch are you still interested in getting this PR in? It needs a rebase. See #4349 for the latest changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants