Initialize proxy prometheus counters values to 0 #4283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
96 tasks
…r registry restart Signed-off-by: Dimitar Kostadinov <dimitar.kostadinov@sap.com>
2404350 to
6ca646c
Compare
|
cc @milosgajdos |
milosgajdos
approved these changes
Mar 2, 2024
|
@thaJeztah, @wy65701436, @squizzi can you help checking this PR? |
Jamstah
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proxy prometheus metrics introduced in #4047 uses labeled counters.
With this PR, counters values are initialized to 0 to mitigate the issue of missing metrics after a registry restart, as recommended here.
For more details related to the issue see Created Timestamps proposal.