Skip to content

test: Skip init if GCS envs are missing #4251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

test: Skip init if GCS envs are missing #4251

wants to merge 1 commit into from

Conversation

erezrokah
Copy link
Contributor

This PR fixes the GCS storage tests to work on forked PRs and on environments that are not configured with GCS.

Looks like the intention of the tests is to skip them when the environment variables are missing, so we can't continue with the initialization.

Another way to do it is to extract the initialization code from init and call it after skipCheck is invoked

@erezrokah erezrokah mentioned this pull request Jan 11, 2024
Merged
@erezrokah
test: Don't try to init if GCS envs are missing
c876347 
Signed-off-by: erezrokah <erezrokah@users.noreply.github.com>
@erezrokah erezrokah force-pushed the test/fix_gsc_skip_logic branch from 6f34a8d to c876347 Compare January 11, 2024 10:45
@erezrokah erezrokah changed the title test: Don't try to init if GCS envs are missing test: Skip init if GCS envs are missing Jan 11, 2024
@milosgajdos
Copy link
Member

We don't actually run integration tests on GCS driver - only on S3 🤔 so I'm curious what do you mean by

GCS storage tests to work on forked PRs

There is also 👉 #4218

@erezrokah
Copy link
Contributor Author

Ah I thought you run them in CI so loading the credentials won't work for forked PRs (those can't access secrets or elevated context in GitHub actions.

As for the linked PR, that works too I'm happy to close this one. Whatever you prefer

@milosgajdos
Copy link
Member

Ah I thought you run them in CI so loading the credentials won't work for forked PRs (those can't access secrets or elevated context in GitHub actions.

We wish but we have no sponsor 😄 so we at least run the S3 ones using minio

As for the linked PR, that works too I'm happy to close this one. Whatever you prefer

I'd like the linked one to be merged in. Feel free to close this one.

@erezrokah erezrokah closed this Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erezrokah @milosgajdos