Skip to content

Conversation

erezrokah
Copy link
Contributor

The PR labeler workflow uses v5 of the action but with a v4 configuration so it fails.

This should fix it (I think), see https://github.com/actions/labeler/tree/17086b774338d2689ada0d8fcc8c51b5c9bc782a#breaking-changes-in-v5

@milosgajdos
Copy link
Member

Can you sign your commit

Signed-off-by: erezrokah <erezrokah@users.noreply.github.com>
@erezrokah erezrokah force-pushed the chore/migrate_to_v5 branch from 310dcbf to b1d1be8 Compare January 16, 2024 15:22
@erezrokah
Copy link
Contributor Author

Can you sign your commit

Done

Copy link
Member

@milosgajdos milosgajdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL @Jamstah

Copy link
Collaborator

@Jamstah Jamstah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need **/*, ** will do it.

erezrokah and others added 2 commits January 16, 2024 18:54
Co-authored-by: James Hewitt <james.hewitt@gmail.com>
Signed-off-by: Erez Rokah <erezrokah@users.noreply.github.com>
Signed-off-by: Erez Rokah <erezrokah@users.noreply.github.com>
@erezrokah erezrokah requested a review from Jamstah January 16, 2024 16:56
@erezrokah
Copy link
Contributor Author

We don't need **/*, ** will do it.

💯 Updated all the places I used **/* to **

Copy link
Collaborator

@Jamstah Jamstah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@milosgajdos milosgajdos merged commit 1611bd2 into distribution:main Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants