Skip to content

Conversation

erezrokah
Copy link
Contributor

Missed this in #4256

charts/registry/config/**/* doesn't exist so I'm assuming this should be only configuration. Kept the top entry so everything is nicely sorted

Signed-off-by: erezrokah <erezrokah@users.noreply.github.com>
Copy link
Member

@milosgajdos milosgajdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL @thaJeztah

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

we should consider sorting this file alphabetically; that may make it slightly less likely for duplicates to be added accidentally

@erezrokah
Copy link
Contributor Author

we should consider sorting this file alphabetically; that may make it slightly less likely for duplicates to be added accidentally

You can see an example workflow to sort JSON and YAML files here https://github.com/cloudquery/cloudquery/blob/e7c97482779c6847c157a7e5dcf7666ca8b53985/.github/workflows/auto_sort_files.yml

You might want to use a different approach to trigger (we do it on a schedule, and you can chose to do it on each PR)

@thaJeztah
Copy link
Member

A validation step is probably ok (not always a fan of bots opening PRs), but sorting the file "once" to set a baseline would probably already be a good start.

@milosgajdos
Copy link
Member

@erezrokah mind sorting the file alphabetically? I think it's a reasonable suggestion, though might be funky hard to enforce

Signed-off-by: erezrokah <erezrokah@users.noreply.github.com>
@erezrokah
Copy link
Contributor Author

@erezrokah mind sorting the file alphabetically? I think it's a reasonable suggestion, though might be funky hard to enforce

Done in a626871

I can do it in a separate PR if you prefer

@milosgajdos milosgajdos merged commit 969bc4a into distribution:main Jan 16, 2024
@erezrokah erezrokah deleted the chore/fix_pr_labeler branch January 16, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants