This isn't needed here. This is a unit test, we only skip integration tests

fails downstream with

       > --- FAIL: TestClientTransport (0.00s)
       >     --- FAIL: TestClientTransport/SkipVerify_true (0.00s)
       >         s3_test.go:225: failed to create driver: no region parameter provided
       >     --- FAIL: TestClientTransport/SkipVerify_false (0.00s)
       >         s3_test.go:225: failed to create driver: no region parameter provided

Would be nice if we could run unit tests without setting any required environment variables.

We probably might want to change the test params to avoid reading env vars in unit tests instead of skipping the test completely if they're not set.

		params := map[string]interface{}{
			"region":     os.Getenv("AWS_REGION"),
			"bucket":     os.Getenv("S3_BUCKET"),
			"skipverify": tc.skipverify,
		}

Updated the test to use constant strings instead, removed test skipping.

Actually, you know what. I'm being completely silly here. We should aim to be consistent -- I noticed there are some other unit tests like TestStorageClass that skip tests...can we revert this to your original change? I'm so sorry, xmas holidays fatigue took over my thinking 😵‍💫

Sure, no problem. :)

We probably might want to change the test params to avoid reading env vars in unit tests instead of skipping the test completely if they're not set.

Also wondering indeed if (as a follow-up) these unit-tests should ultimately get a t.SetEnv (if these env-vars are needed (but not actually make connections)) or otherwise some setupTest(t) if something actually needs to be set up (from a quick test, it looks like these may not be very 'unit" tests"

using t.Setenv is complicated because we construct the driver in the init func 🤔 something to think about for sure

Yeah, not a huge fan of init() but also haven't looked closely