feat: add PR labeler #4205
feat: add PR labeler #4205
Conversation
|
I've got nothing against this, but do we really have the volume to need it? What would we use the classifications for? We don't have multiple squads or anything... |
|
It's just nice to have. There is no real importance to it I agree. I tend to add these labels manually and recently found it annoying, so I figured why not automate it away. |
.github/labeler.yml
Outdated
| gcs: | ||
| - registry/storage/gcs | ||
|
|
||
| azure: |
There was a problem hiding this comment.
Is this the label that is applied? (so if registry/storage/azure is touched, we apply azure as label?)
Because we have existing area/xxx labels; I think it would make sense to use those (same for various other ones);
There was a problem hiding this comment.
We have the manually created ones by us. Labeler action will create new ones but it's OK IMHO. We can always clean up the old cruft.
There was a problem hiding this comment.
I like the area/xx prefixes, as they are clear on what "dimension" the label is for. 😅
There was a problem hiding this comment.
Ok will change, sir 😄
There was a problem hiding this comment.
Ok I've updated them all. Now the labeler will use all the existing labels and they have area prefix 😄
.github/labeler.yml
Outdated
| vendor: | ||
| - vendor/**/* |
There was a problem hiding this comment.
This should probably use the dependencies label (and we should remove the area/vendor label, but first relabel existing PRs if it's used)
There was a problem hiding this comment.
Maybe this could be changed to go.mod instead of the vendor dir 🤔
There was a problem hiding this comment.
Yes, I was considering adding those, but also thought changing those should also modify the vendor directory, so perhaps not needed.
There was a problem hiding this comment.
I've actually added both go.mod and go.sum to this matcher. It does no harm 😄
Having the classifications can really help finding back PR's and tickets when the list of PR's and tickets grows. GitHub's search isn't great (far from), so only searching for keywords often becomes problematic. Combining keywords with specific labels can help narrow down results. In addition we can consider using these labels for generating release notes. For moby/moby, we also have
|
|
Updated PTAL @thaJeztah |
.github/labeler.yml
Outdated
| area/config: | ||
| - charts/registry/config/**/* | ||
|
|
||
| documentation: |
There was a problem hiding this comment.
Perhaps we could rename the existing label to also be area/docs, but we can do in a follow-up if you prefer.
.github/labeler.yml
Outdated
| @@ -0,0 +1,50 @@ | |||
| GHA: | |||
There was a problem hiding this comment.
oh! missed this one; looks like we have area/ci; that's worth updating before merging
|
Will squash and then merge. |
This is an initial commit to kickstart a conversation about how we want the new PRs to be labeled. TBC. Signed-off-by: Milos Gajdos <milosthegajdos@gmail.com>
c921067 to
e96fce1
Compare
|
OMG this is stuck on the DCO. I'm merging, because the commit is signed and Gh need to fix their cruft. |
This PR adds a labeler action that automatically adds labels to PRs based on matched paths (see here).
We can do some quite elaborate things but this is an initial PR to kickstart a conversation about how we want the new PRs to be labelled. TBC.
PTAL @thaJeztah