Skip to content

Conversation

Jiralite
Copy link
Member

Please describe the changes this PR makes and why it should be merged:
This pull request emits deprecation warnings to deprecated parts of the library.

This was not done for MessageEmbed#type as that was just a property (though it could technically be made into a getter?) and the application events that don't emit at all.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@iCrawl iCrawl added this to the Version 13.4 milestone Nov 16, 2021
The output didn't show the names of the methods/getters which may confuse where this was being emitted from.
Copy link
Member

@kyranet kyranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing that the typings already have @deprecated, LGTM.

@suneettipirneni
Copy link
Member

Another message can be added as a result of #6889

@advaith1
Copy link
Contributor

can permission functions warn on usage of the USE_*_THREADS permissions?

@Jiralite
Copy link
Member Author

can permission functions warn on usage of the USE_*_THREADS permissions?

I can for sure check them in Permissions#any, Permissions#has & Permissions#missing but I'm not sure if I can for the rest of the methods. They're implemented from the parent class of which conflicting bits may be a possibility from other extended classes... but it's a start?

@iCrawl iCrawl merged commit 2a0dedf into discordjs:main Nov 23, 2021
@Jiralite Jiralite deleted the deprecations branch November 23, 2021 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

8 participants