CI: Use tsd for Testing Types
#6983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladfrangu
reviewed
Nov 13, 2021
GodderE2D
reviewed
Nov 14, 2021
iCrawl
reviewed
Nov 16, 2021
Co-authored-by: Noel <buechler.noel@outlook.com>
|
CI is failing. Also, isn't the new file very similar to our |
|
The test.ts file is the same file, it's just showing as a new file in the diff. |
iCrawl
approved these changes
Nov 18, 2021
…ypes/tsd-tests
|
I'll just move forward to merge this, since it is a better alternative to maintaining some util functions ourselves and have proper testing this way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Uses the
tsdpackage to run tests on types. This allows more nuanced type checking thantsc, and provides clear output when types don't match.Not all of theassertType's have been replaced, I've only done a few to demo how it works.Status and versioning classification: