refactor(MessageEmbed): Utilise an object approach for .setAuthor()
#6966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems more suitable.
almeidx
requested changes
Nov 10, 2021
Co-authored-by: Almeida <almeidx@pm.me>
vladfrangu
requested changes
Nov 11, 2021
Comment on lines
+351
to
+353
| * @property {string} name The name of this author. | ||
| * @property {string} [url] The URL of this author. | ||
| * @property {string} [iconURL] The icon URL of this author. |
kyranet
requested changes
Nov 11, 2021
kyranet
approved these changes
Nov 11, 2021
vladfrangu
approved these changes
Nov 12, 2021
SpaceEEC
approved these changes
Nov 16, 2021
iCrawl
approved these changes
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
As described in #6963, accessing the last parameter when one did not need the parameter before led to an ungraceful situation. This pull request resolves #6963.
Status and versioning classification: