Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dimonomid/nerdlog
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.8.0
Choose a base ref
...
head repository: dimonomid/nerdlog
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.8.1
Choose a head ref
  • 3 commits
  • 4 files changed
  • 2 contributors

Commits on May 20, 2025

  1. fix: Forget queued commands when reconnecting 

    `LStreamClient` is able to queue commands to be executed once the
current command is done, but these queued commands need to be forgotten
when we're reconnecting, and they weren't, so this commit fixes that.

Ideally I also want to add a test for it, but it requires implementing
support for custom ssh session start command (instead of just shell),
which requires more thought, so it's left for later.
    @dimonomid
    dimonomid committed May 20, 2025
    Configuration menu
    Copy the full SHA
    04cbe37 View commit details
    Browse the repository at this point in the history

  2. fix: Use /bin/sh as the main ssh session shell 

    Previously nerdlog was using the login shell via ssh (which was causing
problems with shells like `fish`), and locally it was using
`/usr/bin/env bash`, which is a bit insonsistent with the ssh conns.

Note that we can't remove the dependency on `bash` completely yet,
because the agent script still relies on bash-specific features and it's
not easy to change (e.g. I do want to use the `PIPESTATUS` and there's
no real equivalent in POSIX). But at least the main ssh session doesn't
need any bash-specific features, and using `/bin/sh` is the most
reasonable thing there.
    @dimonomid
    dimonomid committed May 20, 2025
    Configuration menu
    Copy the full SHA
    10e3551 View commit details
    Browse the repository at this point in the history

  3. chore(master): release 1.8.1 (#35) 

    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    @github-actions
    github-actions[bot] authored May 20, 2025
    Configuration menu
    Copy the full SHA
    9ea0140 View commit details
    Browse the repository at this point in the history
Loading