fix(path): broken tag/category link when containing a dot #368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Turns out category links have the same problem. I think that's all? |
|
@wtchangdm That's all. Thanks. |
|
Hi, @wtchangdm There is a discussion on the Hugo forum: And there seems to be a perfect solution for East Asia words and dots. I make it a partial in |
|
OK, I understand, thanks for the effort!
Dillon <notifications@github.com> 於 2020年5月18日 週一 17:29 寫道：
… Hi, @wtchangdm <https://github.com/wtchangdm>
When handling East Asia words, such as Chinese, urlize will encode them,
which causes .Site.GetPage to fail.
There is a discussion on the Hugo forum:
https://discourse.gohugo.io/t/how-decode-urls-in-hugo/7549
And there seems to be a perfect solution for East Asia words and dots.
I make it a partial in function/path.html.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#368 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALZQXKQRUAUXL54UXXT6CLRSD5Y7ANCNFSM4NDMSRMQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thank you for this great theme! I noticed an issue that certain tags (like
Node.js) at footer disappear somehow.After some investigations, it looks like the same problem as this: HugoBlox/hugo-blox-builder@4ed72d8
I've confirmed that this fixes the issue and other tags are still working fine.