Skip to content
This repository was archived by the owner on Mar 13, 2024. It is now read-only.

New work calculation at block 600000 (soft fork) #36

Merged
merged 1 commit into from
Nov 25, 2015
Merged

New work calculation at block 600000 (soft fork) #36

merged 1 commit into from
Nov 25, 2015

Conversation

MentalCollatz
Copy link
Contributor

First off, this will fix the safe mode warnings once and for all. But it does so much more than that. Currently, an attacker can 51% attack the network with roughly 60% of SHA256D and nothing else. After this change, an attacker with 90% of the SHA256D hashrate and 33% of each of the other 4 algorithms would have insufficient hashpower to mount a 51% attack.

The new formula was chosen as a function of the difficulties and based on these criteria:

  1. It should be a symmetric funtion
  2. It should be order 1 homogenous
  3. It should be homogenous with respect to each variable

Or in plain English:

  1. There should be nothing algorithm-specific (such as per-algorithm weights) nor should it depend on which algorithm actually solved the block.
  2. If all difficulties double, the block work should double
  3. If one difficulty doubles, the block work should change by some constant factor

There is only one function (save multiplication by a constant factor) satisfying all 3 conditions: the geometric mean. As an added bonus, because of how the difficulty algorithm works the geometric mean can change by at most 3% from block to block (which addresses the safe-mode warning issue).

In order to 51% attack the network, the product of the attacker's hashrates must exceed the product of the network's hashrates. In particular, the attacker must have some hashrate in all 5 algorithms.

@MentalCollatz MentalCollatz mentioned this pull request Jan 31, 2015
Closed
@terrylai
Copy link

terrylai commented Feb 4, 2015

Hello, MentalCollatz,

I am Terry, an employee of Tofugear, which is a collaborative company with Digbyte. I am new to analyse the theory and implementation of digibyte core code. So the following saying might be my misunderstanding. Please feel free to point out that if I am wrong.

From Digibyte source code,

digibyte/src/main.h

Line 862 in b43ee15

CBigNum GetBlockWorkAdjusted() const

the final work value has been taken the average.

The GetBlockWorkAdjusted function, which returns GetBlockWork()*GetAlgoWorkFactor()
and the GetAlgoWorkFactor() function gives a factor so that every final value from GetBlockWorkAdjusted will give a reasonable average work value.

So in conclusion it might not be a big help for your change, though it takes the real mean.

Besides, I want to ask that why in src/main.h line 888,

  •        bnRes <<= 7;

you multiply the value by shifting left 7 bits? Is it to make the value somewhat near the old values before change?

BR,
Terry

@MentalCollatz
Copy link
Contributor Author

Hi Terry,

The problem with GetAlgoWorkFactor() is that it it is based on heuristics that change over time. For example the work factor for Skein is currently much lower than it should be and the work factor for SHA2d is much higher than it should be. This results in 2 major problems:

  1. The total "work" contributed by SHA2d is greater than the other 4 algorithms combined. Consequently, SHA256d is weak against 51% attacks.
  2. Safe mode can be triggered on a single-block fork. The warning conditions are basically looking for a fork where a lot of work has been done, using the current tip as a reference point. But the work-per-block can vary so wildly that we see a lot of false positives on the check.

Shifting the value left by 7 is to protect DigiByte from 51% attacks during the transition to the new work formula. Without it, an attacker with just a couple ASICs would be able to start a fork a few blocks before the transition and later broadcast it and undo thousands of legitimate blocks.

MC

@terrylai
Copy link

terrylai commented Feb 7, 2015

Hello, MentalCollatz,

I am Terry again. Recently I am testing your new fork suggestion.

I have tested scrypt algo and will continue to test the other algos. It is working well.

However, I have one question about your nth root function.

You are using approximation method to find the result.

I remembered that for approximation methods such as Newton's method are not guaranteed to be convergent, and it is mentioned in this following link.

http://en.wikipedia.org/wiki/Newton%27s_method

You have stated the 3 criteria, is it for the reason of convergence?

If not and once the result is not convergent, I studied that you have not had special handling in the function such as using old work value.

Please feel free to discuss this so as to keep safe and strict the mining job.

Have a nice weekend!

BR,
Terry

@MentalCollatz
Copy link
Contributor Author

Hi Terry,

Regarding the convergence of Netwon's method, things change when you restrict the values to integers. The wikipedia article only considers arbitrary precision arithmetic.

It remains important to have a good starting approximation. During testing I found that the function did not always converge if I used a 1-bit starting approximation. Sometimes it would oscillate between 2 values close to the answer. However, using a 2-bit approximation converged in every test case. The final version uses an 8-bit approximation. I ran hours of stress tests and never hit a case in which the number of loop iterations ever exceeded 10. The loop condition is just defensive programming.

MC

@digibyte digibyte merged commit 2839671 into digibyte:master Nov 25, 2015
@protonn protonn mentioned this pull request Apr 25, 2017
Merged
digibyte pushed a commit that referenced this pull request Feb 16, 2018
Squashed 'src/univalue/' changes from 16a1f7f6e..fe805ea74
619bb05 
fe805ea74 Declare single-argument (non-converting) constructors "explicit"
8a2d6f1e3 Merge pull request #41 from jgarzik/get-obj-map
ba341a20d Add getObjMap() helper method.  Also, constify checkObject().
ceb119413 Handle .pushKV() and .checkObject() edge cases.
107db9829 Add ::push_back(double) method for feature parity.
d41530031 Move one-line implementation of UniValue::read() to header.
52e85b35b Move exception-throwing get_* methods into separate implementation module.
dac529675 README.md: update code quotes
3e31dcffb README.md: close code quote
d09b8429d Update README.md
f1b86edb4 Convert README to markdown style.
1dfe464ef Import UniValue class unit tests from bitcoin project.
0d3e74dd1 operator[] takes size_t index parameter (versus unsigned int)
640158fa2 Private findKey() method becomes size_t clean, and returns bool on failure.
709913585 Merge pull request #36 from ryanofsky/pr/end-str
a31231b51 Version 1.0.3
4fd5444d1 Reject unterminated strings
81eba332b Merge pull request #26 from isle2983/pushBackHelpers
36405413e Merge PR #32 from branch 'nul-not-special' of git://github.com/ryanofsky/univalue into merge
89bb07322 Merge pull request #31 from ryanofsky/raw-literals
511008c36 Merge pull request #30 from ryanofsky/test-driver
77974f3a9 Merge pull request #34 from paveljanik/20161116_Wshadow_codepoint
a38fcd355 Do not shadow member variable codepoint.
fd32d1ab8 Don't require nul-terminated string inputs
0bb1439d0 Support parsing raw literals in UniValue
28876d045 Merge pull request #29 from btcdrak/exportspace
839ccd71f Add test driver for JSONTestSuite
26ef3fff1 Remove trailing whitespace from JSON export
cfa0384d6 Convenience wrappers for push_back-ing integer types
REVERT: 16a1f7f6e Merge #3: Pull upstream
REVERT: daf1285af Merge pull request #2 from jgarzik/master
REVERT: f32df99e9 Merge branch '2016_04_unicode' into bitcoin
REVERT: 280b191cb Merge remote-tracking branch 'jgarzik/master' into bitcoin
REVERT: 2740c4f71 Merge branch '2015_11_escape_plan' into bitcoin

git-subtree-dir: src/univalue
git-subtree-split: fe805ea74f8919382720b09a905a14e81311b3ad
@ghost
Copy link

ghost commented Jul 1, 2018 •
edited by ghost
Loading

Hi MentalCollatz,

  1. I want to understand WHY you believe "an attacker with 90% of the SHA256D hashrate and 33% of each of the other 4 algorithms would have insufficient hashpower to mount a 51% attack". I don't see why this claim is true, neither from the explanation in this pull request or the source code in it.
  2. I saw no testcases that convincingly reproduce these condititions: a testcase that attempts this attack.
  3. You said "I ran hours of stress tests and never hit a case in which the number of loop iterations ever exceeded 10." I didn't see a copy of these testcases in the code base. How can I run them? I also didn't see a copy of the testcase output for all these hours.

I also have a question, because I don't know and want to understand. If this type of security is so groundbreaking, why do practically zero other cryptocurrencies (and researchers, and mathematicians, and software engineers) use it?

Chime in when you're ready https://www.reddit.com/r/Digibyte/comments/8v4u9r/why_does_in_digibyte_an_attacker_with_90_of_the/

Thanks.

SmartArray pushed a commit to SmartArray/digibyte that referenced this pull request Apr 22, 2021
@gto90
Merge pull request digibyte#36 from SmartArray/tests/qt
3952da3 
test: correct qt tests
Knorre added a commit to Knorre/digibyte that referenced this pull request Oct 26, 2021
@Knorre
Squashed commit of the following:
d21050d 
commit 0b8a04f
Merge: 82414be 2bd62c0
Author: Jared Tate <13957390+JaredTate@users.noreply.github.com>
Date:   Sun Aug 22 13:03:30 2021 -0600

    Merge pull request digibyte#227 from DigiByte-Core/develop

    Updated README

commit 2bd62c0
Merge: 47da24a 4873870
Author: gto90 <33842337+gto90@users.noreply.github.com>
Date:   Thu Jul 29 14:39:46 2021 -0500

    Merge pull request digibyte#59 from mctrivia/patch-3

    small wording changes

commit 4873870
Author: Matthew Cornelisse <squarerootofnegativeone@gmail.com>
Date:   Fri Jul 23 20:07:06 2021 -0500

    small wording changes

    adjusted wording for clarity and to remove telegram and mailing list.

commit 47da24a
Merge: 9b3eff2 74a57c7
Author: ycagel <33166838+ycagel@users.noreply.github.com>
Date:   Tue Jul 13 18:30:16 2021 -0700

    Merge pull request digibyte#54 from DigiByte-Core/bugfix/updated-contribution-md

    Docs: Replaced IRC references with Gitter references

commit 74a57c7
Author: GTO90 <gto90@protonmail.com>
Date:   Tue Jul 13 09:44:20 2021 -0400

    Replaced additional instances of IRC references with Gitter

    * Removed additioanl references to IRC with links to the project Gitter chat.

commit 6183aa2
Author: GTO90 <gto90@protonmail.com>
Date:   Mon Jul 12 22:09:39 2021 -0400

    Updated the contribution.md

    * Updated the contribution.md file to point contributors to this github repositories Gitter channel.

commit 9b3eff2
Merge: 0dbba6d a57f772
Author: GTO90 <gto90@protonmail.com>
Date:   Mon Jun 14 08:33:45 2021 -0500

    Merge branch 'master' into develop

commit a57f772
Merge: 5ac15f5 977011d
Author: gto90 <33842337+gto90@users.noreply.github.com>
Date:   Mon Jun 14 08:32:20 2021 -0500

    Merge pull request digibyte#50 from Jolly-Pirate/patch-1

    Update Qt 5.9 source URL

commit 977011d
Author: drakos <4613678+Jolly-Pirate@users.noreply.github.com>
Date:   Mon May 24 12:27:49 2021 -0400

    Update Qt 5.9 source URL

    The Windows binaries fail to build because of an invalid Qt 5.9 URL. As it turns out, https://download.qt.io/official_releases/qt/ doesn't provide that version anymore, the minimum official version is 5.12. However, Qt 5.9 can be found at the archive https://download.qt.io/archive/qt/5.9/

commit 0dbba6d
Author: gto90 <33842337+gto90@users.noreply.github.com>
Date:   Fri May 14 10:58:46 2021 -0500

    Update README.md

    Added Gitter chat badge.

commit 5d0107e
Merge: a15b8d8 386a192
Author: gto90 <33842337+gto90@users.noreply.github.com>
Date:   Thu May 13 07:27:39 2021 -0500

    Merge pull request digibyte#49 from ChillingSilence/update/ycagelgpgkey

    Update: GPG key for ycagel

commit a15b8d8
Merge: 02bfbf7 5ac15f5
Author: GTO90 <gto90@protonmail.com>
Date:   Wed May 12 21:34:44 2021 -0500

    Merge tag 'v7.17.3' into develop

    v7.17.3

    # gpg: Signature made Wed May 12 21:34:44 2021 CDT
    # gpg:                using RSA key 63250DC0970025475B4E25FF0939B74825FD3E8C
    # gpg: Good signature from "GTO90 <gto90@protonmail.com>" [ultimate]

commit 5ac15f5
Merge: 509db20 258afac
Author: GTO90 <gto90@protonmail.com>
Date:   Wed May 12 21:34:43 2021 -0500

    Merge branch 'release/v7.17.3'

commit 386a192
Author: ChillingSilence <Josiah@c2s.co.nz>
Date:   Wed May 12 07:22:10 2021 +1200

    Added GPG for ycagel

commit 258afac
Merge: 02bfbf7 7d21fac
Author: gto90 <33842337+gto90@users.noreply.github.com>
Date:   Tue May 11 11:10:16 2021 -0500

    Merge pull request digibyte#48 from ChillingSilence/update/moregpgkeys

    Update: Added further GPG keys

commit 7d21fac
Author: ChillingSilence <Josiah@c2s.co.nz>
Date:   Tue May 11 18:38:53 2021 +1200

    Further gpg keys

commit 02bfbf7
Merge: 583bd07 e78d4cb
Author: gto90 <33842337+gto90@users.noreply.github.com>
Date:   Mon May 10 21:36:38 2021 -0500

    Merge pull request digibyte#47 from ChillingSilence/update/gpgkeys

    Update: gpg keys

commit e78d4cb
Author: ChillingSilence <Josiah@c2s.co.nz>
Date:   Tue May 11 14:00:50 2021 +1200

    Added GTO90 and John gpg keys

commit f0f5997
Author: ChillingSilence <Josiah@c2s.co.nz>
Date:   Tue May 11 13:58:13 2021 +1200

    Removed BTC gpg keys, updated mine

commit 583bd07
Merge: e756d45 509db20
Author: GTO90 <gto90@protonmail.com>
Date:   Mon May 10 20:55:27 2021 -0500

    Merge tag 'v7.17.3' into develop

    v7.17.3

    # gpg: Signature made Mon May 10 20:55:26 2021 CDT
    # gpg:                using RSA key 63250DC0970025475B4E25FF0939B74825FD3E8C
    # gpg: Good signature from "GTO90 <gto90@protonmail.com>" [ultimate]

commit 509db20
Merge: 82414be 8bcd769
Author: GTO90 <gto90@protonmail.com>
Date:   Mon May 10 20:55:26 2021 -0500

    Merge branch 'release/v7.17.3'

commit 8bcd769
Merge: efb1ac9 e756d45
Author: GTO90 <gto90@protonmail.com>
Date:   Mon May 10 20:54:02 2021 -0500

    Merge branch 'develop' into release/v7.17.3

commit e756d45
Merge: afe4c82 1c855b4
Author: gto90 <33842337+gto90@users.noreply.github.com>
Date:   Mon May 10 20:36:51 2021 -0500

    Merge pull request digibyte#46 from SmartArray/refactor/readme

commit efb1ac9
Merge: 4823b56 afe4c82
Author: GTO90 <gto90@protonmail.com>
Date:   Mon May 10 08:12:42 2021 -0500

    Merge branch 'develop' into release/v7.17.3

commit afe4c82
Merge: afeea3f a8c0d21
Author: gto90 <33842337+gto90@users.noreply.github.com>
Date:   Mon May 10 07:48:40 2021 -0500

    Merge pull request digibyte#45 from ycagel/develop

    Updated README

commit 1c855b4
Author: Yoshi Jäger <yoshi@jaeger.berlin>
Date:   Mon May 10 06:40:27 2021 +0200

    Fixed COPYING shield

commit 5544a74
Author: Yoshi Jäger <yoshi@jaeger.berlin>
Date:   Mon May 10 06:40:11 2021 +0200

    Added Logo in README

    Logo will change its color when dark mode is enabled (modern browsers only, e.g. Chrome).

commit b21adce
Author: Yoshi <yoshi@jaeger.berlin>
Date:   Mon May 10 06:21:41 2021 +0200

    Added DigiByte Logo (with dark mode support)

commit a8c0d21
Author: ycagel <33166838+ycagel@users.noreply.github.com>
Date:   Sun May 9 15:18:03 2021 -0700

    Updated README

    Updated circulating supply, updated current block reward, added details of Odocrypt HF and removed stale/outdated information

commit 4823b56
Merge: 7a4890b afeea3f
Author: GTO90 <gto90@protonmail.com>
Date:   Sun May 9 11:01:33 2021 -0500

    Merge branch 'develop' into release/v7.17.3

commit afeea3f
Merge: 880e510 e0fb972
Author: gto90 <33842337+gto90@users.noreply.github.com>
Date:   Sun May 9 09:45:34 2021 -0500

    Merge pull request digibyte#44 from ChillingSilence/develop

commit 7a4890b
Merge: 880e510 6ddab91
Author: gto90 <33842337+gto90@users.noreply.github.com>
Date:   Sun May 9 09:27:19 2021 -0500

    Merge pull request digibyte#43 from ChillingSilence/fix/versionbump-release

commit e0fb972
Author: ChillingSilence <Josiah@c2s.co.nz>
Date:   Sun May 9 15:03:16 2021 +1200

    Updated the Gitian build process

commit 6ddab91
Author: ChillingSilence <Josiah@c2s.co.nz>
Date:   Sat May 8 08:33:24 2021 +1200

    Removed version from image to save future hassles

commit 893d4bb
Author: ChillingSilence <josiah@c2s.co.nz>
Date:   Sat May 8 08:16:09 2021 +1200

    Bumped version to 7.17.3 for release

commit 880e510
Merge: c554b8c 4c52fdc
Author: gto90 <33842337+gto90@users.noreply.github.com>
Date:   Sun May 2 12:32:25 2021 -0500

    Merge pull request digibyte#41 from ChillingSilence/fix/README-CI

    Docs: Updated README with badges

commit 4c52fdc
Author: Yoshi Jäger <github@jaeger.berlin>
Date:   Sun May 2 06:22:59 2021 +0200

    Updated branch of commit badge

commit 82c031e
Author: Chilling_Silence <ChillingSilence@users.noreply.github.com>
Date:   Sat May 1 22:50:01 2021 +1200

    Update README.md

    Use develop, not master

    Co-authored-by: Marvin \0x1f977 <7430964+marpme@users.noreply.github.com>

commit efb871f
Author: ChillingSilence <josiah@c2s.co.nz>
Date:   Thu Apr 29 22:06:40 2021 +1200

    Fix capitalization - Make lowercase as with others

commit 9a4f014
Author: ChillingSilence <josiah@c2s.co.nz>
Date:   Thu Apr 29 22:03:31 2021 +1200

    Add open PRs as well as closed

commit 7bf34d1
Author: ChillingSilence <josiah@c2s.co.nz>
Date:   Thu Apr 29 21:56:03 2021 +1200

    Updated README with badges

commit c554b8c
Merge: 5799e15 55ad95e
Author: Jared Tate <13957390+JaredTate@users.noreply.github.com>
Date:   Tue Apr 27 14:47:17 2021 -0600

    Merge pull request digibyte#33 from SmartArray/refactor/subsidy

    Refactor Subsidy Code

commit 55ad95e
Merge: 24b4d23 292915b
Author: Yoshi Jäger <yoshi@jaeger.berlin>
Date:   Tue Apr 27 19:26:12 2021 +0200

    Merge pull request digibyte#3 from SmartArray/tests/ci

    Merge with branch tests/ci

commit 5799e15
Merge: a0b60fa 292915b
Author: gto90 <33842337+gto90@users.noreply.github.com>
Date:   Tue Apr 27 09:39:07 2021 -0500

    Merge pull request digibyte#40 from SmartArray/tests/ci

    Execute Continuous Integration on new PRs

commit 292915b
Merge: 9ef8c04 a0b60fa
Author: Yoshi Jäger <github@jaeger.berlin>
Date:   Thu Apr 22 06:40:12 2021 +0200

    Merge branch 'develop' into tests/ci

commit 9ef8c04
Author: Yoshi Jäger <yoshi@jaeger.berlin>
Date:   Thu Apr 22 06:28:40 2021 +0200

    Added on pull_request event

commit a0b60fa
Merge: 3e91eef 2d34e96
Author: gto90 <33842337+gto90@users.noreply.github.com>
Date:   Wed Apr 21 09:16:47 2021 -0500

    Merge pull request digibyte#39 from SmartArray/tests/ci_workflow

    Continuous Integration: GitHub Workflow

commit 3e91eef
Merge: 3952da3 ce1a1ae
Author: gto90 <33842337+gto90@users.noreply.github.com>
Date:   Tue Apr 20 17:36:50 2021 -0500

    Merge pull request digibyte#38 from DigiByte-Core/tests/disable_subsidy_testnet

    Disable TESTNET Subsidy Tests

commit 3952da3
Merge: 83dbc7d dff0c0b
Author: gto90 <33842337+gto90@users.noreply.github.com>
Date:   Tue Apr 20 17:28:17 2021 -0500

    Merge pull request digibyte#36 from SmartArray/tests/qt

    test: correct qt tests

commit 83dbc7d
Merge: ef8618e 8df59ff
Author: gto90 <33842337+gto90@users.noreply.github.com>
Date:   Tue Apr 20 17:27:46 2021 -0500

    Merge pull request digibyte#37 from SmartArray/tests/txvalidationcache_sync

    test follow-up: fixed locking issue in tx_validationcache_tests

commit ef8618e
Merge: 9acd362 c9a9cb2
Author: gto90 <33842337+gto90@users.noreply.github.com>
Date:   Tue Apr 20 17:24:28 2021 -0500

    Merge pull request digibyte#35 from SmartArray/tests/util-test

    test: correct util-test

commit 2d34e96
Author: Yoshi Jäger <yoshi@jaeger.berlin>
Date:   Tue Apr 20 12:08:27 2021 +0200

    Added missing key

commit a332188
Author: Yoshi Jäger <yoshi@jaeger.berlin>
Date:   Tue Apr 20 12:07:32 2021 +0200

    Added missing version specifier

commit 4e2eb05
Author: Yoshi Jäger <yoshi@jaeger.berlin>
Date:   Tue Apr 20 12:05:16 2021 +0200

    Initial Caching Implementation

    Enable caching for apt dependencies as well as for `depends` subdirectory

commit 5bba63b
Author: Yoshi Jäger <yoshi@jaeger.berlin>
Date:   Tue Apr 20 07:18:52 2021 +0200

    Updating dependency build cache

commit 42f0e1b
Author: Yoshi Jäger <yoshi@jaeger.berlin>
Date:   Sat Apr 17 14:38:33 2021 +0200

    Create ci-coverage.yml

    Run `make check` every time a code push happens.

commit ce1a1ae
Author: Yoshi Jäger <github@jaeger.berlin>
Date:   Tue Apr 20 12:35:15 2021 +0200

    Disable TESTNET Subsidy Tests

    Disable Testnet Subsidy Test in order to save about three minutes.

commit 486e000
Author: Yoshi Jäger <yoshi@jaeger.berlin>
Date:   Tue Apr 20 12:08:27 2021 +0200

    Added missing key

commit 0486ba0
Author: Yoshi Jäger <yoshi@jaeger.berlin>
Date:   Tue Apr 20 12:07:32 2021 +0200

    Added missing version specifier

commit b9ff20f
Author: Yoshi Jäger <yoshi@jaeger.berlin>
Date:   Tue Apr 20 12:05:16 2021 +0200

    Initial Caching Implementation

    Enable caching for apt dependencies as well as for `depends` subdirectory

commit eb52d8f
Author: Yoshi Jäger <yoshi@jaeger.berlin>
Date:   Tue Apr 20 07:18:52 2021 +0200

    Updating dependency build cache

commit e0ebf92
Author: Yoshi <yoshi@jaeger.berlin>
Date:   Tue Apr 20 06:17:23 2021 +0200

    Fixed non-determinism of txvalidationcache_tests by disabling Strict-DER checking until block 1251 (regtest-only)

commit 8df59ff
Author: Yoshi <yoshi@jaeger.berlin>
Date:   Tue Apr 20 06:17:23 2021 +0200

    Fixed non-determinism of txvalidationcache_tests by disabling Strict-DER checking until block 1251 (regtest-only)

commit 9acd362
Merge: 1cb4d6b 6fd5e0f
Author: gto90 <33842337+gto90@users.noreply.github.com>
Date:   Mon Apr 19 19:53:54 2021 -0500

    Merge pull request digibyte#34 from ChillingSilence/fix/dnsseed

    Fix: Update dnsseeds for mainnet / testnet

commit a5c94bb
Author: Yoshi <yoshi@jaeger.berlin>
Date:   Sun Apr 18 10:42:14 2021 +0200

    Resolved locking issue for txvalidationcache-tests

commit e8b34b1
Merge: f98f8df dff0c0b
Author: Yoshi <yoshi@jaeger.berlin>
Date:   Sun Apr 18 07:39:12 2021 +0200

    Merge branch 'tests/qt' of https://github.com/SmartArray/digibyte into tests/ci

commit dff0c0b
Author: Yoshi <yoshi@jaeger.berlin>
Date:   Sun Apr 18 07:29:11 2021 +0200

    Fix: Qt Tests

commit f98f8df
Author: Yoshi Jäger <yoshi@jaeger.berlin>
Date:   Sat Apr 17 14:38:33 2021 +0200

    Create ci-coverage.yml

    Run `make check` every time a code push happens.

commit c9a9cb2
Author: Yoshi <yoshi@jaeger.berlin>
Date:   Sat Apr 17 14:02:00 2021 +0200

    Fixed digibyte-util-test

commit 6fd5e0f
Author: ChillingSilence <Josiah@c2s.co.nz>
Date:   Sat Apr 17 10:24:30 2021 +1200

    Adding more dnsseeds to the list

commit c976edf
Author: ChillingSilence <Josiah@c2s.co.nz>
Date:   Tue Apr 13 17:00:34 2021 +1200

    Update dnsseeds, remove stale entries

commit 24b4d23
Author: Yoshi <yoshi@jaeger.berlin>
Date:   Mon Apr 12 17:46:30 2021 +0200

    Removed dead code

commit d54c650
Author: Yoshi <yoshi@jaeger.berlin>
Date:   Fri Apr 2 14:24:01 2021 +0200

    Refactored Subsidy Code

    Added more comments and merged GetDGBSubsidy and GetBlockSubsidy

commit 1cb4d6b
Merge: e70d45a 3001119
Author: gto90 <33842337+gto90@users.noreply.github.com>
Date:   Mon Apr 12 08:36:41 2021 -0500

    Merge pull request digibyte#32 from SmartArray/tests/wallet_tests_3

    test: correct wallet_tests

commit e70d45a
Merge: 1855d90 1dde1ec
Author: gto90 <33842337+gto90@users.noreply.github.com>
Date:   Mon Apr 12 08:36:25 2021 -0500

    Merge pull request digibyte#19 from SmartArray/tests/main_tests

    test: correct main_tests (subsidy)

commit 3001119
Merge: e0ee675 1855d90
Author: Yoshi Jäger <github@jaeger.berlin>
Date:   Thu Apr 8 07:05:56 2021 +0200

    Merge branch 'develop' into tests/wallet_tests_3

commit e0ee675
Author: Yoshi <yoshi@jaeger.berlin>
Date:   Thu Apr 8 06:35:07 2021 +0200

    Fix: Wallet Tests

commit 1855d90
Merge: 1cc3eca 9c9d1c1
Author: gto90 <33842337+gto90@users.noreply.github.com>
Date:   Wed Apr 7 10:50:19 2021 -0500

    Merge pull request digibyte#30 from SmartArray/tests/txindex_tests

    test: correct txindex_tests

commit 1cc3eca
Merge: e86e4fa 442ee72
Author: gto90 <33842337+gto90@users.noreply.github.com>
Date:   Wed Apr 7 10:44:08 2021 -0500

    Merge pull request digibyte#29 from SmartArray/tests/validation_block_tests

    test: correct validation_block_tests

commit e86e4fa
Merge: 849997d 6fb4774
Author: gto90 <33842337+gto90@users.noreply.github.com>
Date:   Wed Apr 7 10:41:53 2021 -0500

    Merge pull request digibyte#28 from SmartArray/tests/rpc_tests

    test: correct rpc_tests

commit 849997d
Merge: da15583 05d6ccb
Author: gto90 <33842337+gto90@users.noreply.github.com>
Date:   Wed Apr 7 10:41:46 2021 -0500

    Merge pull request digibyte#26 from SmartArray/tests/versionbits_tests

    test: correct versionbits_test

commit da15583
Merge: 7323711 ae74c4d
Author: gto90 <33842337+gto90@users.noreply.github.com>
Date:   Wed Apr 7 10:38:19 2021 -0500

    Merge pull request digibyte#23 from SmartArray/tests/pow_tests

    test: correct pow_tests

commit 7323711
Merge: 05a407c 30330b2
Author: gto90 <33842337+gto90@users.noreply.github.com>
Date:   Wed Apr 7 10:38:06 2021 -0500

    Merge pull request digibyte#22 from SmartArray/tests/miner_tests

    test: correct miner_tests

commit 05a407c
Merge: 4b8ded0 a9032a4
Author: gto90 <33842337+gto90@users.noreply.github.com>
Date:   Wed Apr 7 10:37:54 2021 -0500

    Merge pull request digibyte#21 from SmartArray/tests/denialofservice_tests

    test: correct denialofservice_tests

commit 4b8ded0
Merge: 5e5122a f0656a6
Author: gto90 <33842337+gto90@users.noreply.github.com>
Date:   Wed Apr 7 10:37:31 2021 -0500

    Merge pull request digibyte#18 from SmartArray/tests/key_tests

    test: correct key_tests

commit 5e5122a
Merge: 3832a2d 30d16f8
Author: gto90 <33842337+gto90@users.noreply.github.com>
Date:   Wed Apr 7 10:37:17 2021 -0500

    Merge pull request digibyte#17 from SmartArray/tests/key_io_tests

    test: correct key_io_tests

commit 442ee72
Author: Yoshi <yoshi@jaeger.berlin>
Date:   Wed Apr 7 07:30:03 2021 +0200

    Added consensus.nMinerConfirmationWindow

commit 9020320
Author: Yoshi <yoshi@jaeger.berlin>
Date:   Thu Apr 1 09:10:38 2021 +0200

    Included missing header file for boost (bind/placeholders)

commit 05d6ccb
Author: Yoshi <yoshi@jaeger.berlin>
Date:   Tue Apr 6 05:49:58 2021 +0200

    Fix: Versionbits Tests

commit 5b060a1
Author: Yoshi <yoshi@jaeger.berlin>
Date:   Mon Apr 5 12:24:47 2021 +0200

    Fix: ValidationBlockTests

commit 9c9d1c1
Author: Yoshi <yoshi@jaeger.berlin>
Date:   Mon Apr 5 07:02:43 2021 +0200

    Fixed txindex_tests

commit 6fb4774
Author: Yoshi <yoshi@jaeger.berlin>
Date:   Sun Apr 4 15:22:40 2021 +0200

    Fix: RPC Tests

commit ae74c4d
Author: Yoshi <yoshi@jaeger.berlin>
Date:   Sun Apr 4 06:58:55 2021 +0200

    Fix: pow_tests

commit 30330b2
Author: Yoshi <yoshi@jaeger.berlin>
Date:   Sun Apr 4 06:08:45 2021 +0200

    Removed nHeight debug output

commit 56f829f
Author: Yoshi <yoshi@jaeger.berlin>
Date:   Sun Apr 4 05:55:40 2021 +0200

    Fix: miner_tests

commit a9032a4
Author: Yoshi <yoshi@jaeger.berlin>
Date:   Sat Apr 3 06:38:50 2021 +0200

    Fix: denialofservice_tests

commit 1dde1ec
Author: Yoshi <yoshi@jaeger.berlin>
Date:   Fri Apr 2 15:22:49 2021 +0200

    Introduced optimization and documented some code blocks

commit 5747bb3
Author: Yoshi <yoshi@jaeger.berlin>
Date:   Fri Apr 2 14:00:16 2021 +0200

    Fixed main_tests for supply curve

commit f0656a6
Author: Yoshi <yoshi@jaeger.berlin>
Date:   Fri Apr 2 06:23:17 2021 +0200

    key_tests vectors adapted to DigiByte Network Parameters

commit 3832a2d
Merge: 5462e50 db58b1e
Author: gto90 <33842337+gto90@users.noreply.github.com>
Date:   Thu Apr 1 09:09:32 2021 -0500

    Merge pull request digibyte#11 from barrystyle/tests/blockchain_tests

    test: correct blockchain_tests

commit 5462e50
Merge: 941dfc8 0637d9b
Author: gto90 <33842337+gto90@users.noreply.github.com>
Date:   Thu Apr 1 09:08:28 2021 -0500

    Merge pull request digibyte#15 from barrystyle/tests/blockencodings_tests

    test: correct blockencodings_tests

commit 30d16f8
Author: Yoshi <yoshi@jaeger.berlin>
Date:   Thu Apr 1 13:19:15 2021 +0200

    Corrected key_io_tests

commit 0de9a4d
Author: Yoshi <yoshi@jaeger.berlin>
Date:   Thu Apr 1 09:10:38 2021 +0200

    Included missing header file for boost (bind/placeholders)

commit db58b1e
Author: Yoshi Jäger <github@jaeger.berlin>
Date:   Thu Apr 1 13:17:19 2021 +0200

    Added comment

commit 0637d9b
Author: Yoshi <yoshi@jaeger.berlin>
Date:   Thu Apr 1 09:10:38 2021 +0200

    Included missing header file for boost (bind/placeholders)

commit 941dfc8
Merge: 82414be 841133a
Author: gto90 <33842337+gto90@users.noreply.github.com>
Date:   Sat Mar 20 18:31:24 2021 -0500

    Merge pull request digibyte#12 from DigiByte-Core/bugfix/Deleted-Adware.MAC.Generic.14355

    Trivial: Deleted file containing Adware.MAC.Generic.14355

commit 841133a
Merge: 135e35c 098d068
Author: gto90 <33842337+gto90@users.noreply.github.com>
Date:   Sun Mar 14 21:47:16 2021 -0500

    Merge pull request digibyte#13 from DigiByte-Core/feature/README-Format-Fix

    Docs: Updated README.md

commit 098d068
Merge: 3b42f20 1166be0
Author: gto90 <33842337+gto90@users.noreply.github.com>
Date:   Sun Mar 14 21:46:44 2021 -0500

    Merge pull request digibyte#14 from DigiByte-Core/feature/CONTRIBUTING-Format-Fix

    Docs: Updated CONTRIBUTING.md

commit 43929b5
Author: barrystyle <barrystyle@westnet.com.au>
Date:   Sat Mar 13 12:21:08 2021 +0800

    test: correct blockencodings_tests

    since digibyte has moved to an alternate multi-pow hashing function,
    the original test fails due to a bad memory access.

commit 1166be0
Author: GTO90 <gto90@protonmail.com>
Date:   Fri Mar 12 19:54:26 2021 -0600

    Updated CONTRIBUTING.md

    This pull request updates the CONTRIBUTING.md file to follow MD formatting guidelines and strict linting rules.

    Additionally, this pull request updates the `Contributor Workflow` section which adds GitFlow as the official branching methodology and developer workflow.

    Finally, better formatted and organized language describing the pull request philosophy, peer review process and merging process.

commit 3b42f20
Author: GTO90 <gto90@protonmail.com>
Date:   Fri Mar 12 19:39:42 2021 -0600

    Updated README

    This pull request updates the README.md file to follow MD formatting guidelines and strict linting rules.

    Additionally, this pull request introduces a `Development Process` section which explains the DigiByte branching structure and methodology.

    Finally, more precise language is introduced in the `Testing` section to highlight the necessity of including unit tests for all proposed code changes and the testing & validation process the should occur by the reviewer.

commit 135e35c
Author: GTO90 <gto90@protonmail.com>
Date:   Fri Mar 12 15:35:28 2021 -0600

    Deleted Adware.MAC.Generic.14355 File

    A scan of the directories discovered a file infected with Adware.  Adware.MAC.Generic has been categorized as an adware infection. This is an unwanted application whose main purpose is gaining revenue for its developers by displaying numerous untrusted adverts on a user’s computer.

    More can be learned about this Adware here: http://threatonmac.com/adware-mac-generic-virus-removal/

commit 2d8894b
Author: barrystyle <barrystyle@westnet.com.au>
Date:   Tue Mar 9 14:03:37 2021 +0800

    test: correct blockchain_tests

    the original blockchain_tests expects genesis to be sha256d mindiff
    rather than digibyte's genesis which is scrypt mindiff.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MentalCollatz @terrylai @digibyte