uptime checks: add crud methods #1386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tried to see how far I could get adding support for uptime checks and
alerts in a day, and this is what I could do.
This is still missing:
* Integration tests,
* More in-depth tests for the `create` check operation, since I added
a bit of extra functionality over the default API interaction,
* The `get state` method for checks. It has a different displayable
type, so it was too much work for today,
* All of the uptime alerts, since it's a separate set of endpoints.
Not sure if we want to merge as-is, but I figured it's probably better
than not having the functionality. I'll try to complete it on the next
free Friday.
|
|
||
| DigitalOcean Uptime Checks provide the ability to monitor your endpoints from around the world, | ||
| and alert you when they're slow, unavailable, or SSL certificates are expiring.`, | ||
| }, |
There was a problem hiding this comment.
Suggested change
| }, | |
| GroupID: manageResourcesGroup, | |
| }, |
After #1387 landed, we need to remember to GroupID to get them categorized right. As is, it shows up under Additional Commands.
Also, should this maybe be nested under the existing monitoring command? That would mirror the control panel experience.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried to see how far I could get adding support for uptime checks and alerts in a day, and this is what I could do.
This is still missing:
createcheck operation, since I added a bit of extra functionality over the default API interaction,get statemethod for checks. It has a different displayable type, so it was too much work for today,Not sure if we want to merge as-is, but I figured it's probably better than not having the functionality. I'll try to complete it on the next free Friday.