Skip to content

fix(realease): correct tag regex to strictly match SemVer vX.Y.Z format. #1715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 6, 2025
Merged

fix(realease): correct tag regex to strictly match SemVer vX.Y.Z format. #1715

merged 3 commits into from
Aug 6, 2025

Conversation

Thedarkmatter10
Copy link
Contributor

🛠 What this PR fixes

The current on.push.tags pattern in the tagged-release workflow incorrectly matches some invalid tags and misses valid SemVer tags. Specifically:

  • ✅ It matches invalid tags like:

    • v2x3.4 (because . matches any character)
    • v1-2-3 or v1.2x3
    • v10.0.0 is ignored due to [1-9] limitation

    FInd attached SCREENSHOT BELOW

issueSEMVER

  • ❌ It misses valid tags like:
    • v0.1.0
    • v1.24
    • v1.2

✅ Fix

This PR replaces the regex:

from: 'v[1-9].[0-9]+.[0-9]+'
to:   '^v[0-9]+\.[0-9]+(\.[0-9]+)+$'

FIND ATTACHED FIXED SemVer SCREENSHOT .

semVERfixed

@SSharma-10 SSharma-10 merged commit 9ba8c2c into digitalocean:main Aug 6, 2025
9 checks passed
@kishlay-singh-DO kishlay-singh-DO mentioned this pull request Aug 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SSharma-10 SSharma-10 SSharma-10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Thedarkmatter10 @SSharma-10