Gen AI Knowledge Base Implementation #1702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
da32cee to
9075487
Compare
ff2f9cb to
f371e32
Compare
476457a to
19ccbdd
Compare
ecc1715 to
b6c022d
Compare
b6c022d to
68b174d
Compare
|
Can we rename knowledge_base.go to genai_knowledge_base.go ? would be consistent with genai_agent.go |
There was a problem hiding this comment.
Pull Request Overview
This PR implements GenAI Knowledge Base features, adding methods, commands, displayers, and integration tests to support full CRUD and data‐source management.
- Extended the
GenAIServiceinterface and its implementation with Knowledge Base and Data Source methods. - Added CLI commands and displayers for Knowledge Base operations (
create,list,get,update,delete, attach/detach, data‐source add/list/delete). - Added integration tests and mocks covering all new endpoints.
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| do/genai.go | Added KnowledgeBase* types and service methods. |
| commands/genai_knowledge_base.go | Added CLI commands for Knowledge Base endpoints. |
| commands/displayers/genai.go | Added displayers for Knowledge Base and Data Sources. |
| do/mocks/GenAIService.go | Added mocks for all Knowledge Base service methods. |
| integration/knowledgebase_test.go | Added end-to-end integration tests for each operation. |
Comments suppressed due to low confidence (2)
args.go:753
- The comment for
ArgKnowledgeBaseItemPathis incorrect; it should describe the item path for a data source (e.g.,// ArgKnowledgeBaseItemPath is the item path within a Spaces data source).
// ArgKnowledgeBaseItemPath is the region of the knowledge base
commands/genai_knowledge_base.go:181
- The placeholder
<knowledgebase-uuid>is missing a hyphen and should be<knowledge-base-uuid>to match the command naming convention and usage elsewhere.
"detach <agent-uuid> <knowledgebase-uuid>",
ca3c34d to
619e59a
Compare
harshmaru7
reviewed
Jul 4, 2025
SSharma-10
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented methods for Knowledge base endpoints for the GenAI Service