You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@harshmaru7 are the integration test suites required as we didn't have to add the same for recent products we added doctl support for (e.g. droplet autoscalers, vpc peering). Also they seem to be accomplishing the same objective as the unit tests that I've added with mocking the godo layer. Open to more feedback on this.
@harshmaru7 are the integration test suites required as we didn't have to add the same for recent products we added doctl support for (e.g. droplet autoscalers, vpc peering). Also they seem to be accomplishing the same objective as the unit tests that I've added with mocking the godo layer. Open to more feedback on this.
Please add the integration tests later on since unit tests tests logic in isolation, while integration ensure real-world usage actually works
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.