Fix parsing error due to LE changes #300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixfontein
reviewed
Jun 9, 2025
| @@ -112,8 +112,7 @@ def _poll_until_not(url, pending_statuses, err_msg): | |||
| log.info("{0} Account ID: {1}".format("Registered!" if code == 201 else "Already registered!", acct_headers['Location'])) | |||
| if contact is not None: | |||
| account, _, _ = _send_signed_request(acct_headers['Location'], {"contact": contact}, "Error updating contact details") | |||
| log.info("Updated contact details:\n{0}".format("\n".join(account['contact']))) | |||
|
|
|||
| log.info("Updated contact details:\n{0}".format("\n".join(contact))) | |||
There was a problem hiding this comment.
Why not use
Suggested change
| log.info("Updated contact details:\n{0}".format("\n".join(contact))) | |
| log.info("Updated contact details:\n{0}".format("\n".join(account.get('contact') or []))) |
?
That way the user at least can see that Let's Encrypt didn't store the contact info.
There was a problem hiding this comment.
I'm not that comfortable with python (at least anymore) and this was just a quick and dirty fix. So yeah 😅
There was a problem hiding this comment.
Can we get this approved and merged?
There was a problem hiding this comment.
I will review it soon (have been on vacation)
|
Merged and released version |
This was referenced Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #299.