Skip to content

Don't restrict .box to 80% width #3251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2025
Merged

Conversation

denilsonsa
Copy link
Contributor

Having max-width: 80% is very frustrating.

I can see my browser window has enough space for a wider table, and yet the table cells are squished while leaving empty whitespace at the sides.

This is specially noticeable when using a non-wide monitor and resizing the browser to half of the monitor width. (In my case, 2240x1400 / 2 = 1120x1400.)

@denilsonsa
Copy link
Contributor Author

Before:

image

After (by manually applying the changes in the browser dev tools):

image

@dgtlmoon
Copy link
Owner

dgtlmoon commented Jun 9, 2025

looks nice, the sass/scss needs updating

@denilsonsa
Copy link
Contributor Author

looks nice, the sass/scss needs updating

Oh, that's unusual. We usually only have the source files in the git repository, and any generated files are part of the build process and never added to the repository. In this case, the *.scss would be here, but the *.css wouldn't.

Having `max-width: 80%` is very frustrating.

I can see my browser window has enough space for a wider table, and yet the table cells are squished while leaving empty whitespace at the sides.

This is specially noticeable when using a non-wide monitor and resizing the browser to half of the monitor width. (In my case, 2240x1400 / 2 = 1120x1400.)
@dgtlmoon
Copy link
Owner

dgtlmoon commented Jun 9, 2025

Oh, that's unusual. We usually only have the source files in the git repository, and any generated files are part of the build process and never added to the repository.

In any case, you should have updated the sass, but in your original commit it was the CSS :)

@denilsonsa
Copy link
Contributor Author

In any case, you should have updated the sass, but in your original commit it was the CSS :)

Well, when I found the exact line I needed to change in the .css file, I assumed I had found the right file and didn't look any further. :)

There are errors on the automatic test for Python 3.10, but those cannot be related to my change. Please tell me if any further action is needed from my side.

@dgtlmoon dgtlmoon merged commit c0c2898 into dgtlmoon:master Jun 11, 2025
8 of 10 checks passed
@denilsonsa denilsonsa deleted the patch-1 branch June 11, 2025 09:26
Batwam pushed a commit to Batwam/changedetection.io that referenced this pull request Jun 13, 2025
@flatteringmoth
Copy link

Hello, is it please possible to add options for both? I am on the other side of this issue and it is frustrating having max-width: 100% I do not care if 100% is the default, but no option to change this now is unpleasant, 80% was perfect. Thank you in advance!

@denilsonsa
Copy link
Contributor Author

@flatteringmoth do you mind sharing a screenshot of how it looks, showing why it is worse than before?

I'm not the maintainer, but I guess having an option wouldn't be the best solution. Instead, maybe we can find a solution that works well enough for both cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants