Recent SocketIO changes broke SSL mode #3247
Description
In the latest version SSL mode no longer works with otherwise default configuration causing a crash at startup.
Version
v0.50.2
How did you install?
Docker
To Reproduce
- Start the app with SSL mode e.g.
python ./changedetection.py -s -d /datastore - Web server does not start. See error in the logs
Expected behavior
Web server starts using the default certificate and key file as before or exits gracefully reporting an unsupported configuration.
Actual behavior
Web server does not start.
The following error is logged:
Traceback (most recent call last):
File "/app/./changedetection.py", line 8, in <module>
changedetectionio.main()
File "/app/changedetectionio/__init__.py", line 229, in main
socketio.run(app, host=host, port=int(port), debug=False,
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/flask_socketio/__init__.py", line 660, in run
app.run(host=host, port=port, threaded=True,
File "/usr/local/flask/app.py", line 889, in run
run_simple(t.cast(str, host), port, self, **options)
TypeError: run_simple() got an unexpected keyword argument 'certfile'