Use both offset and render_offset in scale
#88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
offset instead of render_offset in scaleoffset and render_offset in scale
eea05fc to
db55487
Compare
|
This improves Parley's
@xorgy why the breaking change label? This seems like a pretty straightforward bugfix to me. |
|
Alright, slight update on the
So now with the more conservative approach taken to zeno#15, landing this Swash PR no longer depends on the Zeno PR and landing this Swash PR first is actually more important. It's a Swash bugfix that Zeno had a workaround for. With zeno#15 applied, the workaround goes away so Swash needs to be ready for it. |
|
Merging this one as well. As mentioned in zeno#15, subpixel rendering needs to be verified before release. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the Swash half of dfrg/zeno#15, and will require that to land first (and a new version of zeno to be released).
As mentioned there, you could alternatively change the code here to pass in bothoffsetandrender_offsetif you want to avoid a breaking change in zeno.