fix: import client-go authProviders #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pghildiyal
reviewed
Sep 29, 2021
| @@ -7,7 +7,7 @@ require ( | |||
| github.com/getkin/kin-openapi v0.67.0 | |||
| github.com/hashicorp/go-multierror v1.1.1 | |||
| github.com/inconshreveable/mousetrap v1.0.0 // indirect | |||
| github.com/olekukonko/tablewriter v0.0.5 // indirect | |||
| github.com/mgutz/ansi v0.0.0-20200706080929-d51e80ef957d | |||
There was a problem hiding this comment.
Are these changes required in go.mod?
There was a problem hiding this comment.
yes, see #2
$ make
go build -o bin/kubedd .
kubedd/kubedd.go:23:2: package github.com/devtron-labs/silver-surfer/pkg imports github.com/mgutz/ansi from implicitly required module; to add missing requirements, run:
go get github.com/mgutz/ansi@v0.0.0-20200706080929-d51e80ef957d
pghildiyal
approved these changes
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes OP's issue on #3, I'll open a separate issue for the path resolution
Fixes #3
Fixes #2 by importing the missing ansi lib