fix Kubernetes minor server version #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS EKS clusters report their Kubernetes minor version as "19+".
pghildiyal
approved these changes
Sep 28, 2021
pghildiyal
reviewed
Sep 29, 2021
| @@ -64,7 +65,7 @@ func (c *Cluster) ServerVersion() (string, error) { | |||
| if err != nil { | |||
| return "", err | |||
| } | |||
| return fmt.Sprintf("%s.%s", info.Major, info.Minor), nil | |||
| return fmt.Sprintf("%s.%s", info.Major, strings.Trim(info.Minor, "+")), nil | |||
There was a problem hiding this comment.
Should we use regex (\d+)([^\d]*) instead? this will make it agnostic to any other trailing characters also.
There was a problem hiding this comment.
What about parsing from info.GitVersion instead as I suggested in #5 (comment)?
Seems like it will be more stable.
I don't have a GKE cluster to test on but they seem to be following a similar format: https://cloud.google.com/kubernetes-engine/versioning#versioning_scheme
So something like this:
gitVersion := strings.Split(info.GitVersion, ".")
major := strings.Trim(gitVersion[0], "v")
minor := gitVersion[1]
return fmt.Sprintf("%s.%s", major, minor), nilThere was a problem hiding this comment.
Yes, gitVersion appears to be better indicator, lets use this instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS EKS clusters report their Kubernetes minor version as "19+".
Fixes #5