Option to specify docker image hash #185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the option to specify a docker image hash to use for the base vm and for descriptors
devrandom
approved these changes
Jun 18, 2018
devrandom
reviewed
Jun 18, 2018
| # if docker_image_digests are supplied, it must be the same length as suites | ||
| if docker_image_digests.size > 0 and suites.size != docker_image_digests.size | ||
| raise "`suites` and `docker_image_digests` must both be the same size if both are supplied" | ||
| elsif ENV["USE_DOCKER"] and docker_image_digests.size > 0 and suites.size == docker_image_digests.size |
There was a problem hiding this comment.
The third clause here seems superfluous
devrandom
added a commit
that referenced
this pull request
Jun 18, 2018
4053f3c Option to specify docker image hash (Andrew Chow)
|
Thank you. |
maflcko
pushed a commit
to bitcoin/bitcoin
that referenced
this pull request
Jul 15, 2018
86967b2 Add option to use docker for gitian-build.sh (Andrew Chow) Pull request description: Updates gitian-build.sh script for the docker virtualization method recently added to gitian-builder. Second commit depends on devrandom/gitian-builder#185 Tree-SHA512: 0fa50b6c1be35a7a39f4a82816369637d3d0082922ac9876b80ae8156c795dec0ff34ad384b5348777042df8ddb6a72bbaeddd7002ef80557b10e2acf46632aa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the option to specify a docker image hash to use for the base vm and for descriptors