Skip to content

Conversation

mjlabe
Copy link
Contributor

@mjlabe mjlabe commented Sep 6, 2020

C3.js icon from PR #136

c3js-original

c3js-plain

@amacado amacado added the feature:icon PR when a new icon is ready to be added to the collection label Sep 6, 2020
Copy link
Member

@amacado amacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @mjlabe and thanks for your contribution. Looks fine, I would only like to improve the tagging.

mjlabe and others added 2 commits September 7, 2020 10:36
Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com>
@mjlabe
Copy link
Contributor Author

mjlabe commented Sep 8, 2020

Done! @amacado

@Thomas-Boi
Copy link
Member

Hello there,
Recently, we just introduced an automation pipeline to Devicon which will help us create the icons. Before we can merge your changes in, there are a few things that we need to do first:

  1. Merge the current devicon/develop branch into your PR branch. This contains the build script needed for us to build your icons.
  2. Read the CONTRIBUTING.md for things to do before merging and review our icon standards.
  3. Push your changes and/or branches. We will review them once this is done and merge your PR if everything goes well.

Thank you for contributing to this repo. We are sorry that we haven't accept any PR for awhile. Now that we have a build pipeline, we can merge PRs more quickly than before.

We hope to see your icons in the Devicon repo soon :)

Cheers,
Devicon Team

@Thomas-Boi Thomas-Boi added the bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger label Jan 6, 2021
@amacado amacado added the stale PRs that haven't had any activity for a while and old issues label Feb 23, 2021
@Thomas-Boi
Copy link
Member

Hi @mjlabe,

I'm working on merging your PR to accept your icon. However, it seems like your branch is a bit out of date. It'd be much appreciated if you can bring the branch up to date with develop and re-push.

After a week, if the branch hasn't been updated I'll make a new PR cherry-picking your commit. This is to ensure you are still the author of the commit and get proper credits. You can also just give me permission to do it this way now.

It'd be quicker if you update the branch yourself though but whichever works 👍.

You got quite a few icons 😄

@Thomas-Boi
Copy link
Member

Hi @mjlabe, I am unable to find the the official C3.js logo that matches the one you provided. In fact, it looks like your C3.js logo is similar to the D3.js logo but with the D flipped. Here's the logo that I found, which was from this page

If you can provide any proof that your logo is the correct one, we'll accept your icon. Until then, we will have to close this PR.

@Thomas-Boi Thomas-Boi closed this May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger feature:icon PR when a new icon is ready to be added to the collection stale PRs that haven't had any activity for a while and old issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants