-
Notifications
You must be signed in to change notification settings - Fork 2.4k
new icon: C3js (original, plain) #282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @mjlabe and thanks for your contribution. Looks fine, I would only like to improve the tagging.
Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com>
Done! @amacado |
Hello there,
Thank you for contributing to this repo. We are sorry that we haven't accept any PR for awhile. Now that we have a build pipeline, we can merge PRs more quickly than before. We hope to see your icons in the Devicon repo soon :) Cheers, |
Hi @mjlabe, I'm working on merging your PR to accept your icon. However, it seems like your branch is a bit out of date. It'd be much appreciated if you can bring the branch up to date with develop and re-push. After a week, if the branch hasn't been updated I'll make a new PR cherry-picking your commit. This is to ensure you are still the author of the commit and get proper credits. You can also just give me permission to do it this way now. It'd be quicker if you update the branch yourself though but whichever works 👍. You got quite a few icons 😄 |
Hi @mjlabe, I am unable to find the the official C3.js logo that matches the one you provided. In fact, it looks like your C3.js logo is similar to the D3.js logo but with the D flipped. Here's the logo that I found, which was from this page If you can provide any proof that your logo is the correct one, we'll accept your icon. Until then, we will have to close this PR. |
C3.js icon from PR #136